refactor: ds-716 delete unused locale strings #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
refactor: ds-716 delete unused locale strings
Notes:
The locale strings that were deleted are confirmed to be unused. Some of the unused remaining strings are planned for use in the near future during scans and sources unit tests/refactor work. There are inconsistencies in the code regarding translations, such as table locale strings being used in form dialogs. I will create a new Jira story to address these issues in the future to ensure we don't forget about them.
How to test
Coverage and basic unit test check
$ npm install$ npm testInteractive unit test check
$ npm install$ npm run test:watchLocal run check
$ npm install$ npm run startCheck the build
$ npm install$ npm run buildUpdates issue/story
DISCOVERY-716