Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): issues/50 clean up docker review env #55

Merged
merged 1 commit into from
May 31, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): issues/50 clean up docker review env

Notes

  • This is an iteration, where first round we're opting to fix/update the normal build script we use to create the GUI review environment

How to test

Review env

You'll need to run the review environment start script multiple times to see this update actually function. Once it activates you'll see some additions to the console log around Docker clean itself up

  1. sync these updates with your fork then
  2. $ yarn start:review
  3. the first time you run this the clean up may not happen, the second time you run it you'll either see a log message with the following in it (takes a bit...)
      [api:review] 
      [api:review] Cloning QPC...
      [api:review] Untagged: qpc-review:latest
      [api:review] Deleted: sha256:8713790fb7b...
    
    or just
      [api:review] 
      [api:review] Cloning QPC...
      [api:review] Untagged: qpc-review:latest
      ...
    
  4. To restart just type $ yarn start:review again

Example

...

Updates issue/story

Updates #50

@codecov-io
Copy link

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   69.12%   69.12%           
=======================================
  Files          91       91           
  Lines        2131     2131           
  Branches      338      338           
=======================================
  Hits         1473     1473           
  Misses        567      567           
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ef65c...6ff7013. Read the comment docs.

Copy link
Contributor

@kholdaway kholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cdcabrera cdcabrera merged commit 6bf20ec into quipucords:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants