Yak shaving CI

.github/workflows/css-lint.yml

@@ -6,10 +6,6 @@ on:
       - '**/*.css'
       - '.github/workflows/css-lint.yml'
   pull_request:
-    types:
-      - opened
-      - reopened
-      - synchronize
     paths:
       - '**/*.css'
       - '.github/workflows/css-lint.yml'
@@ -18,18 +14,27 @@ jobs:
   stylelint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Node
-        uses: actions/setup-node@v2-beta
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-node@v2-beta
         with:
           node-version: '12'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
       - name: Add Custom Problem Matcher
         run: |
           echo "::add-matcher::.github/matchers/${{ github.job }}.json"  
+
       - name: Install Dependencies
         run: |
-          npm install
+          npm ci
+
       - name: npm run stylelint
         run: |
           npm run stylelint

.github/workflows/javascript-lint.yml

@@ -6,10 +6,6 @@ on:
       - '**/*.js'
       - '.github/workflows/javascript-lint.yml'
   pull_request:
-    types:
-      - opened
-      - reopened
-      - synchronize
     paths:
       - '**/*.js'
       - '.github/workflows/javascript-lint.yml'
@@ -18,15 +14,23 @@ jobs:
   eslint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Node
-        uses: actions/setup-node@v2-beta
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-node@v2-beta
         with:
           node-version: '12'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
       - name: Install Dependencies
         run: |
-          npm install
+          npm ci
+
       - name: npm run lint
         run: |
           npm run lint

.github/workflows/markdown-lint.yml

@@ -6,10 +6,6 @@ on:
       - '**/*.md'
       - '.github/workflows/markdown-lint.yml'
   pull_request:
-    types:
-      - opened
-      - reopened
-      - synchronize
     paths:
       - '**/*.md'
       - '.github/workflows/markdown-lint.yml'
@@ -18,18 +14,27 @@ jobs:
   markdownlint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Node
-        uses: actions/setup-node@v2-beta
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-node@v2-beta
         with:
           node-version: '12'
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
       - name: Add Custom Problem Matcher
         run: |
           echo "::add-matcher::.github/matchers/${{ github.job }}.json"
+
       - name: Install Dependencies
         run: |
-          npm install
+          npm ci
+
       - name: npm run markdownlint
         run: |
           npm run markdownlint

.github/workflows/python-lint.yml

@@ -6,10 +6,6 @@ on:
       - '**/*.py'
       - '.github/workflows/python-lint.yml'
   pull_request:
-    types:
-      - opened
-      - reopened
-      - synchronize
     paths:
       - '**/*.py'
       - '.github/workflows/python-lint.yml'
@@ -18,65 +14,65 @@ jobs:
   black:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Python
-        uses: actions/setup-python@v2
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-python@v2
         with:
           python-version: '3.7'
 
       # Cache pip dependencies
       # See also: https://github.com/actions/cache/blob/main/examples.md#python---pip
       - name: Get pip cache dir
-        id: pip-cache
+        id: pip-dir
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
 
-      - name: pip cache
-        uses: actions/cache@v2
+      - uses: actions/cache@v2
         with:
-          path: ${{ steps.pip-cache.outputs.dir }}
-          key: cactbot-pip-${{ hashFiles('**/requirements.txt') }}
+          path: ${{ steps.pip-dir.outputs.dir }}
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
           restore-keys: |
-            cactbot-pip-
+            ${{ runner.os }}-pip-
 
       - name: Install Dependencies
         run: |
           pip install -r requirements.txt
+
       - name: black **/*.py --line-length 100 --check --diff
         run: |
           black **/*.py --line-length 100 --check --diff
+
   pylint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Python
-        uses: actions/setup-python@v2
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-python@v2
         with:
           python-version: '3.7'
+
       - name: Add Custom Problem Matcher
         run: |
           echo "::add-matcher::.github/matchers/${{ github.job }}.json"
 
       # Cache pip dependencies
       # See also: https://github.com/actions/cache/blob/main/examples.md#python---pip
       - name: Get pip cache dir
-        id: pip-cache
+        id: pip-dir
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
 
-      - name: pip cache
-        uses: actions/cache@v2
+      - uses: actions/cache@v2
         with:
-          path: ${{ steps.pip-cache.outputs.dir }}
-          key: cactbot-pip-${{ hashFiles('**/requirements.txt') }}
+          path: ${{ steps.pip-dir.outputs.dir }}
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
           restore-keys: |
-            cactbot-pip-
+            ${{ runner.os }}-pip-
 
       - name: Install Dependencies
         run: |
           pip install -r requirements.txt
+
       - name: pylint **/*.py --errors-only
         run: |
           pylint **/*.py --errors-only

.github/workflows/test.yml

@@ -8,10 +8,6 @@ on:
       - 'ui/raidboss/**'
       - '.github/workflows/test.yml'
   pull_request:
-    types:
-      - opened
-      - reopened
-      - synchronize
     paths:
       - '**/*.js'
       - '**/*.py'
@@ -22,19 +18,27 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Code
-        uses: actions/checkout@v1
-      - name: Setup Node
-        uses: actions/setup-node@v2-beta
+      - uses: actions/checkout@v1
+
+      - uses: actions/setup-node@v2-beta
         with:
           node-version: '12'
-      - name: Setup Python
-        uses: actions/setup-python@v2
+
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+
+      - uses: actions/setup-python@v2
         with:
           python-version: '3.7'
+
       - name: Install Dependencies
         run: |
-          npm install
+          npm ci
+
       - name: npm test
         run: |
           npm test

requirements.txt

@@ -1,6 +1,7 @@
 # Linting, formatting
 black==19.10b0
 pylint==2.5.3
+
 # dependencies for utils/*.py
 PyYAML
 requests