Better ESM support #1728
Draft
Better ESM support #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Oct 14, 2023
| @@ -21,6 +21,11 @@ export default function exportQUnit (QUnit) { | |||
|
|
|||
There was a problem hiding this comment.
Do you know what it is about module.exports = QUnit; that doesn't work for ESM compat layers? It seems odd to assign module.exports = QUnit; but then (seemingly redundantly) also assign module.exports.test = QUnit.test; to itself. If the transformation layers are based on static analysis, that would explain it, but I thought they were runtime based?
There was a problem hiding this comment.
maybe. as I dug in to this, I think it'd be better to have actual separate builds -- and we're already in a good spot since it seems QUnit is written in ESM -- so we'd just emit a new bundle and wire up package.json#exports so that the import/require/etc are routed correctly.
related questions:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1724
(however, I can't run tests locally, because the browser launcher is puppeteer, and some ancient browser that I don't have installed 😅
)
I had started with an esm.html file to test with, but
script.type=moduledoesn't allow the file protocol when loading modules, so we'd have to use an http server, but then the relative file paths for the link / importmap / script.src wouldn't work the same.