Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix final checkpoint file write #558

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Mar 11, 2024

Description

This fixes the checkpoint/restart failure identified in #554 and adds a GitHub action to test that checkpoint/restart works correctly for the HydroBlast3D test.

Related issues

Fixes #554.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@BenWibking BenWibking added bug Something isn't working do not merge I/O input/output labels Mar 11, 2024
@BenWibking BenWibking changed the title [DO NOT MERGE] checkpoint/restart failure reproducer fix final checkpoint file write Mar 12, 2024
@BenWibking
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BenWibking BenWibking marked this pull request as ready for review March 12, 2024 18:27
@BenWibking BenWibking force-pushed the BenWibking/restart-reproducer branch from 987f89d to fcedd5f Compare March 12, 2024 18:48
@markkrumholz markkrumholz added this pull request to the merge queue Mar 13, 2024
Merged via the queue into development with commit 66d3b80 Mar 13, 2024
16 checks passed
@BenWibking BenWibking deleted the BenWibking/restart-reproducer branch July 31, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I/O input/output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the checkpoint written after the main time loop is corrupted
2 participants