retry hydro update if cooling solve fails #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
psharda
reviewed
Apr 22, 2024
psharda
reviewed
Apr 22, 2024
|
It would be good to edit these two comments to make it consistent for the user. I could not find a way to add a comment on these lines directly (perhaps github only allows providing comments on the lines you changed): quokka/src/RadhydroSimulation.hpp Line 1038 in 435e77c quokka/src/RadhydroSimulation.hpp Line 1305 in 435e77c |
|
@psharda can you re-review? |
psharda
approved these changes
Apr 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
This updates the shock-cloud problem to use a new setup that:
- tracks the cloud center-of-mass frame
- refines so that the cooling length $l_{\text{cool}} = c_s
t_{\text{cool}}$ is resolved with at least 10 cells
- adds derived fields for temperature, entropy, pressure, etc. to the
outputs
- uses the (simplified) Navier-Stokes Characteristic Boundary Conditions
for inflow/outflow on the left/right sides of the box
- adds shock-cloud problem to nightly regression testing
**This PR depends on:**
* #352
* #360
* #363
* #364
* #365
* #366
* #367
* #430
* #581
* #596
* #597
* #598
* #599
* #616
* #645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This triggers the retry mechanism for the hydro update if the cooling solve fails. This mirrors the behavior for the chemistry solve (#615).
Related issues
Closes #372.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.