Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute internalEnergy P dV with face-centered velocities #95

Merged
merged 8 commits into from
Aug 2, 2022
Merged

compute internalEnergy P dV with face-centered velocities #95

merged 8 commits into from
Aug 2, 2022

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Aug 1, 2022 •
edited
Loading

Improvements to the internal energy equation / dual energy method:

  • The face-centered velocity can be saved inside the Riemann solver, so the cell-centered P dV term for the internal energy equation can be computed with a compact stencil.
  • The P dV term is now included in the RK integration rhs, rather than being operator split.

Both of these changes should make the dual energy method more accurate and robust.

@BenWibking BenWibking changed the title compute P dV for internal energy inside Riemann solver compute p dV for internal energy inside Riemann solver Aug 1, 2022
@BenWibking
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@BenWibking BenWibking changed the title compute p dV for internal energy inside Riemann solver compute p dV for internal energy with face-centered velocities Aug 2, 2022
@BenWibking BenWibking changed the title compute p dV for internal energy with face-centered velocities compute internalEnergy P dV with face-centered velocities Aug 2, 2022
@BenWibking
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@BenWibking BenWibking merged commit 0efb41b into development Aug 2, 2022
@BenWibking BenWibking deleted the dual-energy-fixes branch August 2, 2022 09:00
BenWibking added a commit that referenced this pull request Aug 2, 2022
@BenWibking
compute internalEnergy P dV with face-centered velocities (#95)
2323c79 
* save face-centered velocities from Riemann solver

* use unsplit cell-centered P dV term
@BenWibking BenWibking mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenWibking