Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomMemberEvent: add isRejectedInvite(), isBan() and isUnban() #320

Merged
merged 1 commit into from
Mar 9, 2020
Merged

RoomMemberEvent: add isRejectedInvite(), isBan() and isUnban() #320

merged 1 commit into from
Mar 9, 2020

Conversation

krkk
Copy link
Contributor

@krkk krkk commented May 3, 2019

No description provided.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label May 4, 2019
KitsuneRal
KitsuneRal requested changes May 4, 2019
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are quite useful. Please address a few nitpicks as per below.

lib/events/roommemberevent.cpp Outdated Show resolved Hide resolved
lib/events/roommemberevent.cpp Show resolved Hide resolved
lib/events/roommemberevent.cpp Outdated Show resolved Hide resolved
@KitsuneRal KitsuneRal merged commit ef81c79 into quotient-im:master Mar 9, 2020
@krkk krkk deleted the roommemberevent-types branch March 9, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: Version 0.6 - Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krkk @KitsuneRal