Tighten up logging categories stuff #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
KitsuneRal
force-pushed
the
kitsune/logging-tweaks
branch
from
e7e9181
to
bf3746c
Compare
To avoid clashes with similarly named categories in client code.
It should have been updated together with Quaternion's .clang-format in the past but only the Quaternion's one ended up in Git back then. [skip ci]
The header logging.h mixed client-facing and library-internal things. This commit puts library-internal things (which happened to be definitions of logging categories and nothing else) into logging_categories_p.h and client-facing things landed in util.h as there not many of them (a couple of debug manipulators and operator<< overloads).
KitsuneRal
force-pushed
the
kitsune/logging-tweaks
branch
from
bf3746c
to
5352681
Compare
KitsuneRal
force-pushed
the
kitsune/logging-tweaks
branch
from
5352681
to
87d7042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest (by diff) is, effectively, renaming
logging.htologging_categories_p.hand changing it in all the files that include it. Though not strictly necessary, I also moved one inclusion from a header file (basejob.h- the only one remaining) to make sure the library keeps logging categories to itself. Taking the logging categories to Quotient namespace is to avoid linked name clashes with clients (it all started with me addingQ_LOGGING_CATEGORY(MAIN, "quaternion.main")and failing the build with it).Also, the logging categories are defined as
inlinenow, obviating the need oflogging.cppto define them.There were a small number of log lines that didn't have a category at all - this is fixed now.