Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement exporting megolm sessions to a file #761

Merged
merged 20 commits into from
Jul 2, 2024
Merged

Implement exporting megolm sessions to a file #761

merged 20 commits into from
Jul 2, 2024

Conversation

TobiasFella
Copy link
Member

@TobiasFella TobiasFella commented May 25, 2024 •
edited
Loading

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
10.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Jun 14, 2024
@TobiasFella
Copy link
Member Author

test added, should be ready now

@KitsuneRal KitsuneRal self-requested a review June 25, 2024 13:08
KitsuneRal
KitsuneRal reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cleanup things to begin with.

Quotient/keyimport.cpp Outdated Show resolved Hide resolved
Quotient/database.cpp Outdated Show resolved Hide resolved
Quotient/database.cpp Outdated Show resolved Hide resolved
Quotient/keyimport.h Outdated Show resolved Hide resolved
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
KitsuneRal
KitsuneRal reviewed Jun 29, 2024
View reviewed changes
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
KitsuneRal
KitsuneRal reviewed Jun 29, 2024
View reviewed changes
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
KitsuneRal
KitsuneRal reviewed Jun 29, 2024
View reviewed changes
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
KitsuneRal
KitsuneRal reviewed Jun 29, 2024
View reviewed changes
Quotient/room.cpp Outdated Show resolved Hide resolved
KitsuneRal
KitsuneRal reviewed Jun 29, 2024
View reviewed changes
Quotient/room.cpp Outdated Show resolved Hide resolved
@KitsuneRal
Copy link
Member

Aside from things above, LGTM.

TobiasFella and others added 5 commits June 30, 2024 20:41
KitsuneRal
KitsuneRal reviewed Jul 2, 2024
View reviewed changes
Quotient/keyimport.cpp Outdated Show resolved Hide resolved
@KitsuneRal KitsuneRal merged commit fb70c91 into dev Jul 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: 0.9 - Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasFella @KitsuneRal