Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize CBOR data without one allocation per value #772

Merged
merged 1 commit into from
Jul 13, 2024

Commits on Jul 13, 2024

  1. Deserialize CBOR data without one allocation per value

    QCBorValue::toJsonValue checks whether the CBOR data is in the JSON subset,
    which results in one allocation per value. As this is our own serialized
    data here, we don't need that check and can use the CBOR data directly.
    
    The API for that fast path is unfortunately not public, but it's inline
    code, so it doesn't bind us to Qt's unstable internal ABI either.
    
    This saves about 12M allocations during the startup of Itinerary here.
    vkrause committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    0bfdf1e View commit details
    Browse the repository at this point in the history