#28: Add session history to ease request debugging #47
Conversation
ajjn
commented
Mar 8, 2020
ajjn
commented
- To address issue Debug printing the raw json data #28.
README.rst
Outdated
| enable_history_at_loglevel='WARNING') | ||
| # or | ||
| import logging | ||
| logging.basicConfig(level='DEBUG') |
There was a problem hiding this comment.
Are you sure it's a good idea to tie the library to a logging library this way ? What if I want to use some other logging library ? Or if I want to debug in production but don't want to leak this data to eg. sentry via sentry-sdk breadcrumbs or data logging ? I think this is something that should instead be explicitly set, so eg. enable_session_log: bool instead of enable_history_at_loglevel.
There was a problem hiding this comment.
Also, it might be a better idea to allow function callback hooks for this. Eg. hook for received data, hook for sent data etc. That would be much more versatile, and also allows for logging.
There was a problem hiding this comment.
Thanks @katajakasa, I guess you are right! The library user can anyway build whatever logic for binding to log level the way they want, so I will just make it a simple boolean enabled. Adding callback hooks is also a good idea. Let's see what can be done...
