Add trailing_slash
argument to the session
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Django and DRF have a combination of options that makes Django either redirect with 301 or return 404 error when URL is missing a trailing slash before the query params:
https://docs.djangoproject.com/en/3.0/ref/settings/#std:setting-APPEND_SLASH
https://www.django-rest-framework.org/api-guide/routers/#simplerouter
In both cases jsonapi-client fails to fetch the resource because it either faces the 404 or some headers get lost during the redirection, and response doesn't contain a valid JSON.
Suggestion:
I suggest adding an option to the session that would allow to handle this situation.
I might miss some other places where the trailing slash should be appended though :)