Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(modal): provide initial implementation #277

Merged
merged 154 commits into from
Oct 25, 2023
Merged

feature(modal): provide initial implementation #277

merged 154 commits into from
Oct 25, 2023

Conversation

GregOnNet
Copy link
Contributor

@GregOnNet GregOnNet commented Apr 7, 2023 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add a reusable Modal component

Use cases and why

    1. Use a form in a Modal.
    1. Display a notification in a Modal.

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@nx-cloud
Copy link

nx-cloud bot commented May 2, 2023 •
edited
Loading

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

We didn't find any information for the current pull request with the commit f004d05.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

@GregOnNet GregOnNet changed the title chore(devDependencies): add a11y-dialog feature: dialog May 2, 2023
@GregOnNet GregOnNet changed the title feature: dialog feature(dialog): provide initial implementation May 2, 2023
@GregOnNet GregOnNet marked this pull request as ready for review May 12, 2023 11:26
@GregOnNet
Copy link
Contributor Author

@gioboa @shairez maybe one of you can have a look.

I am happy to receive your feedback/wishes.

@GregOnNet GregOnNet force-pushed the feature/dialog branch 3 times, most recently from 28897eb to 89dc27f Compare May 23, 2023 18:23
@GregOnNet GregOnNet changed the title feature(dialog): provide initial implementation feature(modal): provide initial implementation Aug 25, 2023
@GregOnNet GregOnNet force-pushed the feature/dialog branch 3 times, most recently from c6a39fb to 0567f11 Compare October 10, 2023 19:35
GregOnNet and others added 27 commits October 25, 2023 11:50
@GregOnNet
refactor(modal): remove empty keyframe
5422ed0
@GregOnNet
refactor(modal): remove ESC-handler
3fe7976 
- it seems this handler is a noop
@GregOnNet
Revert "refactor(modal): remove ESC-handler"
4a453a8 
This reverts commit 08b09ee.
@thejackshelton @GregOnNet
docs(modal): improved modal readability, animation snippet, beta
99755d4
@thejackshelton @GregOnNet
docs(modal): remove unused examples
75ba5df
@GregOnNet
refactor(modal): make binding of closeOnBackdropClick more expressive
3e1bd4a
@GregOnNet
refactor(modal): extract ESC-Key overriding
e12cfbb
@GregOnNet
refactor(modal): improve property name
542699b
@GregOnNet
refactor(modal): extract modal position fix when scrollbar reappears
c2004cf
@GregOnNet
refactor(modal): remove props binding since it was not used
cee0023
@thejackshelton @GregOnNet
feat(modal): transition support, fixed type errors in spec
0da3e6b
@GregOnNet
feat(modal): require bind:show
99ae628
@GregOnNet
test(modal): ensure opening button is focused after closing
cd87648
@thejackshelton @GregOnNet
docs(modal): note about invokers in the future
1108fa8
@GregOnNet
refactor(modal): register animated/transitioned once
a8bc5b9
@GregOnNet
refactor(modal): simplify modal opening
99b30be
@GregOnNet
test(modal): expecting .modal-showing to be applied after modal has b…
f6ce318 
…een opened
@GregOnNet
refactor(modal): restructure helpers adding animation support
cc6516a
@GregOnNet
refactor(modal): call onShow$ & onClose$ in Modal directly
8353aeb
@GregOnNet
refactor(modal): simplify ESC-handler by using { once: true }
4c3da81
@GregOnNet
refactor(modal): destrucure ...props first on <dialog>
cabdea4
@thejackshelton @GregOnNet
docs(docs): sheet docs examp;le
a030c17
@thejackshelton @GregOnNet
fix(modal): fixing scrollbar flickers
426bf48
@thejackshelton @GregOnNet
docs(docs): fixing the header, making it sticky so there is no layout…
a83d3a5 
… shift
@thejackshelton @GregOnNet
docs(docs): sheet examples
fafbb31
@GregOnNet
refactor(modal): improve naming of helper
e9c57a4
@GregOnNet
refactor(modal): inline BodyScrollOptions
f50b16f
@thejackshelton thejackshelton merged commit fa200f7 into qwikifiers:main Oct 25, 2023
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregOnNet @thejackshelton