Qwil bignumeric #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on' into hotfix/shopify-error-investigation
…n schema conversion
…th empty {} anywhere in it as invalid.
…tests) to be more descriptive + minor style updates to validate_json_schema.py
simplejson is already required by singer-python
Working session with Anže
This is not working - see comments
… pull request adswerve#21 Update singer dependency adswerve#21
… development # Conflicts: # .github/workflows/python-package.yml
…it's more backwards compatible
…I trumps config file.
…velopment # Conflicts: # .github/workflows/python-package.yml
We are running into downstream issues when comparing values from our db that are a direct result of using FLOAT over NUMERIC. These changes remove the hardcoded FLOAT and to opt for the precision of NUMERIC until such a time as the upstream repo has an appropriate fix for this issue (either making it configurable or utilizing NUMERIC as well instead).
paultiplady
force-pushed
the
qwil-bignumeric
branch
from
30cd1d5
to
55b7e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases our patch on top of upstream's https://github.com/adswerve/target-bigquery/tree/0.11.3.