Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementing XEP-0449: Stickers #490

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jbruechert
Copy link
Contributor

@jbruechert jbruechert commented Oct 2, 2022

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
  • Update doc/doap.xml
  • Add unit tests
  • Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 68.51% // Head: 68.56% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (fb6ff05) compared to base (9f9d672).
Patch coverage: 75.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   68.51%   68.56%   +0.05%     
==========================================
  Files         294      294              
  Lines       25340    25788     +448     
==========================================
+ Hits        17361    17681     +320     
- Misses       7979     8107     +128     
Impacted Files Coverage Δ
src/base/QXmppMessage.h 100.00% <ø> (ø)
src/base/QXmppPubSubItem.cpp 100.00% <ø> (ø)
src/base/QXmppPubSubItem.h 75.00% <ø> (ø)
src/base/QXmppStickerPackItem.cpp 71.11% <71.11%> (ø)
src/base/QXmppMessage.cpp 97.98% <83.33%> (-0.33%) ⬇️
src/base/QXmppStickerPackItem.h 100.00% <100.00%> (ø)
tests/qxmppmessage/tst_qxmppmessage.cpp 94.89% <100.00%> (+0.06%) ⬆️
tests/qxmpppubsub/tst_qxmpppubsub.cpp 95.07% <100.00%> (+0.21%) ⬆️
src/base/QXmppFutureUtils_p.h 72.41% <0.00%> (-6.84%) ⬇️
src/base/QXmppError.h 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/base/QXmppMessage.h Outdated Show resolved Hide resolved
@jbruechert jbruechert force-pushed the feature/stickers branch 2 times, most recently from 556e8ce to 86f5e2a Compare October 2, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants