Merge branch 'main' into feat/list_matviews

r-dbi · Apr 3, 2024 · a3dfc02 · a3dfc02
2 parents 15b3cef + a69fce0
commit a3dfc02
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 37 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: RPostgres
 Title: C++ Interface to PostgreSQL
-Version: 1.4.6.9005
-Date: 2024-01-24
+Version: 1.4.6.9006
+Date: 2024-04-02
 Authors@R: c(
     person("Hadley", "Wickham", role = "aut"),
     person("Jeroen", "Ooms", role = "aut"),
@@ -101,7 +101,6 @@ Collate:
     'dbWriteTable_PqConnection_character_data.frame.R'
     'default.R'
     'export.R'
-    'names.R'
     'quote.R'
     'show_PqConnection.R'
     'sqlData_PqConnection.R'

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,40 @@
 <!-- NEWS.md is maintained by https://fledge.cynkra.com, contributors should not edit this file -->
 
+# RPostgres 1.4.6.9006 (2024-04-02)
+
+## Bug fixes
+
+- `dbWriteTable()` correctly handles name clashes between temporary and permanent tables (#402, #431).
+
+- Fix `dbQuoteIdentifier()` for `Id()` objects to no longer rely on names (#460).
+
+## Features
+
+- Breaking change: Avoid appending a numeric suffix to duplicate column names (#463).
+
+## Chore
+
+- Refactor `dbListTables()` et al. (@dpprdan, #413).
+
+- Refactor `list_fields()` (#462).
+
+- Use `Id` in `exists_table()` (#461).
+
+- Add Aviator configuration.
+
+## Documentation
+
+- Use dbitemplate (@maelle, #456).
+
+## Testing
+
+- Test for columns in `dbQuoteIdentifier()` (@dpprdan, #263, #372).
+
+## Breaking changes
+
+- Breaking change: Avoid appending a numeric suffix to duplicate column names (#463).
+
+
 # RPostgres 1.4.6.9005 (2024-01-24)
 
 - Internal changes only.

diff --git a/R/dbColumnInfo_PqResult.R b/R/dbColumnInfo_PqResult.R
@@ -3,7 +3,6 @@
 dbColumnInfo_PqResult <- function(res, ...) {
   rci <- result_column_info(res@ptr)
   rci <- cbind(rci, .typname = type_lookup(rci[[".oid"]], res@conn), stringsAsFactors = FALSE)
-  rci$name <- tidy_names(rci$name)
   rci
 }
 

diff --git a/R/dbFetch_PqResult.R b/R/dbFetch_PqResult.R
@@ -13,7 +13,7 @@ dbFetch_PqResult <- function(res, n = -1, ..., row.names = FALSE) {
   ret <- convert_bigint(ret, res@bigint)
   ret <- finalize_types(ret, res@conn)
   ret <- fix_timezone(ret, res@conn)
-  set_tidy_names(ret)
+  ret
 }
 
 #' @rdname postgres-query

diff --git a/R/names.R b/R/names.R