Use DATAPTR_OR_NULL() in ExtractSubset() when possible
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Jul 14, 2024
src/main/subset.c
Outdated
Comment on lines
148
to
151
| EXTRACT_SUBSET_LOOP(const int* px = (const int*) DATAPTR_OR_NULL(x), | ||
| LOGICAL0(result)[i] = px[ii], | ||
| LOGICAL0(result)[i] = LOGICAL_ELT(x, ii), | ||
| LOGICAL0(result)[i] = NA_LOGICAL); |
There was a problem hiding this comment.
I wonder if something along the following lines would work too, with a suitable implementation above:
Suggested change
| EXTRACT_SUBSET_LOOP(const int* px = (const int*) DATAPTR_OR_NULL(x), | |
| LOGICAL0(result)[i] = px[ii], | |
| LOGICAL0(result)[i] = LOGICAL_ELT(x, ii), | |
| LOGICAL0(result)[i] = NA_LOGICAL); | |
| EXTRACT_SUBSET_LOOP(const int* px = (const int*) DATAPTR_OR_NULL(x), | |
| SET_LOGICAL_ELT, LOGICAL_ELT, NA_LOGICAL); |
SET_LOGICAL_ELT() could be defined as a macro, like in src/main/saveload.c .
DavisVaughan
force-pushed
the
feature/extract-subset-dataptr-or-null
branch
from
0edaded
to
772089c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-devel/r-dev-day#23
https://bugs.r-project.org/show_bug.cgi?id=18766