Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for generating a patch #29

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

MichaelChirico
Copy link
Contributor

No description provided.

Copy link
Member

@daroczig daroczig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked being explicit about the kept file, but I understand it might not be that useful

@MichaelChirico
Copy link
Contributor Author

I liked being explicit about the kept file, but I understand it might not be that useful

I wanted to drop those notes since there are hundreds, quite noisy. maybe we can summarize (by language?) instead?

@daroczig
Copy link
Member

I wanted to drop those notes since there are hundreds, quite noisy.

IMO that's due to accumulating the patch for a year, instead if doing quarterly. and once most languages are added, the number if new files should decrease.

anyway, no hard preference on this, I can always add a few extra log lines if it's my turn of patching :)

@MichaelChirico MichaelChirico changed the title Batch pocount call & empty file removal Update instructions for generating a patch Feb 28, 2024
@MichaelChirico
Copy link
Contributor Author

@daroczig reworked this entirely, PTAL.

Here's what the output looks like for dropping empty files:

Screenshot from 2024-02-27 18-40-43

And for summarizing new translations:

Screenshot from 2024-02-27 18-40-10

@daroczig
Copy link
Member

awesome 🎉

@MichaelChirico
Copy link
Contributor Author

awesome 🎉

taking this as re-approval :) let's iterate otherwise

@MichaelChirico MichaelChirico merged commit f449e20 into main Mar 18, 2024
@MichaelChirico MichaelChirico deleted the MichaelChirico-patch-1 branch March 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants