Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: update status code given invalid query #42

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

dpastoor
Copy link
Contributor

in response to #41

@dpastoor
Copy link
Contributor Author

I have not actually tested this by pulling/building the repo, but I believe this syntax is correct

@gaborcsardi
Copy link
Contributor

Thanks!

@gaborcsardi gaborcsardi merged commit 5f484a1 into r-hub:master Jan 21, 2022
@dpastoor
Copy link
Contributor Author

cool deal - whenever you get to deploying the new version - I'd be happy to test/confirm as well for additional sanity

@gaborcsardi
Copy link
Contributor

It is deployed now.

@dpastoor
Copy link
Contributor Author

awesome - can confirm its working as expected now:

bad path:

curl https://cranlogs.r-pkg.org/downloads/dailylast-week/dplyr -v
...
* Connection state changed (MAX_CONCURRENT_STREAMS == 256)!
< HTTP/2 404 
< date: Fri, 21 Jan 2022 16:25:49 GMT
< content-type: application/json
< vary: Accept-Encoding
< x-powered-by: Express
< cf-cache-status: DYNAMIC
< expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
< report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=fhZiY%2F5RSBMn%2B7uCLks17Tljsy0Xw3%2FmpeCj7cxEY9PiRd%2F9HpBqdo6AbYiSplckIofXvxWFEta2oWXZrHjEIY%2BN0HcTdo6nRg7n02L8PlZyZNtz%2BJhUGOqVTb6DaA2TRaTXk4s%3D"}],"group":"cf-nel","max_age":604800}
< nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
< server: cloudflare
< cf-ray: 6d11e693f8215a16-IAD
< alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400
< 
* Connection #0 to host cranlogs.r-pkg.org left intact
{ "error": "Invalid query",   "info": "https://github.com/metacran/cranlogs.app" }

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants