Skip to content

Commit

Permalink
BUG: Missing spaces in extract_text() method (py-pdf#1328)
Browse files Browse the repository at this point in the history
  • Loading branch information
ssjkamei committed Sep 24, 2024
1 parent d974d5c commit 5400f5a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pypdf/_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -1989,7 +1989,7 @@ def process_operation(operator: bytes, operands: List[Any]) -> None:
if isinstance(op, (str, bytes)):
process_operation(b"Tj", [op])
if isinstance(op, (int, float, NumberObject, FloatObject)) and (
(abs(float(op)) >= _space_width)
(math.ceil(abs(float(op))) >= _space_width)
and (len(text) > 0)
and (text[-1] != " ")
):
Expand Down
17 changes: 17 additions & 0 deletions tests/test_text_extraction.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,20 @@ def test_layout_mode_warnings(mock_logger_warning):
mock_logger_warning.assert_called_with(
"Argument visitor_text is ignored in layout mode", "pypdf._page"
)


@pytest.mark.enable_socket()
def test_space_with_one_unit_smaller_than_font_width():
"""Tests for #1328"""
url = "https://github.com/py-pdf/PyPDF2/files/9498481/0004.pdf"
name = "iss1328.pdf"
reader = PdfReader(BytesIO(get_data_from_url(url, name=name)))
page = reader.pages[0]
extracted = page.extract_text().split("Description:")[1].split("8/11/22")[0].strip()
assert """Reporting crude oil leak.
Leak was isolated to well
pad. Segment of line was
immediately isolated, now
estimated at 5 barrels of oil
spilt. Root cause still
unknown at this time.""" == extracted

0 comments on commit 5400f5a

Please sign in to comment.