Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested quarto action in setup-r-dependencies@v2 breaks workflow in restricted Organization setup #901

Closed
solmos opened this issue Aug 6, 2024 · 2 comments · Fixed by #904

Comments

@solmos
Copy link

solmos commented Aug 6, 2024

Is your feature request related to a problem? Please describe.
My GitHub Organization only allows to use specific minor release versions (vX.X.X) of untrusted third-party actions, and they consider that quarto-dev/quarto-actions/setup falls under this category (r-lib actions do not). Thus the nested quarto-dev/quarto-actions/setup@v2 action in [email protected] introduced in 67f8747 causes all workflows to fail due to the version used for the quarto action. This occurs even if we set install-quarto: false, since the workflow will first check if all the actions required by a given action can be downloaded.

Describe the solution you'd like
If this dependency in quarto-dev/quarto-actions/setup is desirable, a solution would be to include an input parameter in r-lib/actions/setup-r-dependencies for specifying the version of the quarto action.

Describe alternatives you've considered
We could use [email protected] but we would be stuck with an outdated action forever.

@gaborcsardi
Copy link
Member

My GitHub Organization only allows to use specific minor release versions (vX.X.X) of untrusted third-party actions,

That is a pretty weird policy, considering, that these tags are merely labels, that can be changed later, whether they are minor release versions or not.

But I guess we can use a minor version of that action, no problem.

a solution would be to include an input parameter in r-lib/actions/setup-r-dependencies for specifying the version of the quarto action.

I am fairly sure that you cannot parameterize action versions. The action versions of a workflow run are resolved up front, before any parameters are considered.

gaborcsardi added a commit that referenced this issue Aug 7, 2024
gaborcsardi added a commit that referenced this issue Aug 7, 2024
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants