New {.bullets } style

[gaborcsardi]

New {.bullets } style

To collapse vectors into bullets:

❯ cli_text("Some values {.bullets {letters[1:5]}} blah blah")
Some values • a
• b
• c
• d
• e blah blah

Right now you need to add newlines explicitly at the beginning and at the end:

❯ cli_text("Some values\f{.bullets {letters[1:5]}}\f blah blah")
Some values
• a
• b
• c
• d
• e
blah blah

It can be combined with markup, but the markup has to be nested inside:

❯ cli_text("Some values\f {.bullets {.val {letters[1:5]}}}\f blah blah")
Some values
• "a"
• "b"
• "c"
• "d"
• "e"
blah blah

@jennybc Should we always add line breaks at the beginning and the end?

Closes #265.

[lionel-]

Looks great!

I agree that introducing newlines automatically around bullet lists would be more user friendly since that's the desired formatting 99% of the time.

[gaborcsardi]

I agree that introducing newlines automatically around bullet lists would be more user friendly since that's the desired formatting 99% of the time.

True, but it is easy to add newlines with \f, and if we make them the default, then there is currently no way to remove them.

[gaborcsardi]

True, but it is easy to add newlines with \f, and if we make them the default, then there is currently no way to remove them.

OTOH we can always make a different class for that later, if it turns out to be needed.

[lionel-]

Or maybe we could add newlines like this? It seems more readable:

cli::cli_text("
  Some values
  {.bullets {letters[1:5]}}
  blah blah
")

(sorry if that doesn't make sense in the cli DSL with which I'm not familiar yet)

[gaborcsardi]

Or maybe we could add newlines like this? It seems more readable:

Yeah, \n is just space in cli_text(), so you can wrap text in your editor and it will be re-wrapped to the screen width when printing. Hence the \f.

[lionel-]

Is the leading space in the block of text ignored or is it taken literally?

If blocks of text are the default way of using cli, then having to use \f for the inline cases seem fine. It requires knowing the difference between \n and \f in the context of cli but that's not too bad.

[gaborcsardi]

Leading space is ignored, yeah:

❯ cli::cli_text("    foo bar")
foo bar

[gaborcsardi]

But I really don't mind putting in the newlines by default, I think we both agree that that's most common.