Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent single tildes from becoming strikethrough #31

Closed
wants to merge 2 commits into from

Conversation

zkamvar
Copy link

@zkamvar zkamvar commented May 9, 2024

This will fix #25.

@jeroen
Copy link
Member

jeroen commented May 10, 2024

This is does much more than fix the roundtrip? It disables parsing of single-tilde strikethroughs which I think many people actually use?

@zkamvar
Copy link
Author

zkamvar commented May 10, 2024

This is does much more than fix the roundtrip? It disables parsing of single-tilde strikethroughs which I think many people actually use?

Yeah, that's a good point, which was brought up in github/cmark-gfm#71 (comment). This change also means that the tildes are now escaped, so I'm going to close this.

@zkamvar zkamvar closed this May 10, 2024
@zkamvar zkamvar deleted the znk-fix-25 branch May 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subscript text is converted to strikethrough
2 participants