Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new log_echo and log_warning arguments #118

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Add new log_echo and log_warning arguments #118

merged 7 commits into from
Feb 14, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Feb 9, 2023

Making it easier to log code and warnings to stderr() as knitr works

@hadley hadley marked this pull request as ready for review February 13, 2023 21:59
Copy link
Collaborator

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Other than TRUE/FALSE, do you want to allow for specifying the connection directly, e.g., log_echo = stdout()?

@hadley
Copy link
Member Author

hadley commented Feb 14, 2023

I don’t think so? I think these are only really useful for stderr. OTOH in some cases it might be useful to log to a file, and it’s easy enough to implement so might as well do it.

@yihui
Copy link
Collaborator

yihui commented Feb 14, 2023

Okay.

@yihui yihui merged commit ce9157b into main Feb 14, 2023
@yihui yihui deleted the logging branch February 14, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants