Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preview docs/tests/implementation #2650

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Improve preview docs/tests/implementation #2650

merged 4 commits into from
Jun 10, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 10, 2024

No description provided.

@hadley hadley requested a review from olivroy June 10, 2024 13:39
Copy link

github-actions bot commented Jun 10, 2024

Copy link
Collaborator

@olivroy olivroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to test interactively right now, but let me know if you have more planned changes in this area (Local preview workflow). I will test again once you have finalized changes in this area

NEWS.md Outdated Show resolved Hide resolved
R/preview.R Outdated Show resolved Hide resolved
R/preview.R Outdated Show resolved Hide resolved
R/preview.R Outdated Show resolved Hide resolved
@hadley
Copy link
Member Author

hadley commented Jun 10, 2024

No more changes planned; I just saw this in passing.

@hadley hadley merged commit 2caf625 into main Jun 10, 2024
14 checks passed
@hadley hadley deleted the preview-tidying branch June 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants