Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo which prevents finding templates #2669

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Jun 19, 2024

Follow up from #2556.

This triggers an error in template packages that provide template elements which don't exist in pkgdown, such as the carpentries/varnish package.

Error in `purrr::map_chr()`:
ℹ In index: 5.
Caused by error in `map_()`:
! Can't find template for "content-chapter".
---
Backtrace:
    ▆
 1. └─sandpaper::build_lesson()
 2.   └─sandpaper:::build_site(...)
 3.     └─sandpaper::build_episode_html(...)
 4.       └─sandpaper:::build_html(...)
 5.         └─pkgdown::render_page(...)
 6.           └─pkgdown:::render_page_html(pkg, name = name, data = data, depth = depth)
 7.             └─purrr::map_chr(pieces, find_template, name = name, pkg = pkg)
 8.               └─purrr:::map_("character", .x, .f, ..., .progress = .progress)

It solves the issue locally and seems correct based on the fact docs indeed say template.package.

With h/t to @froggleston for pinpointing where the issue may come from.

@hadley hadley merged commit 3c2fcb9 into r-lib:main Jun 19, 2024
15 checks passed
@hadley
Copy link
Member

hadley commented Jun 19, 2024

Oops! Thanks for the fix.

@Bisaloo Bisaloo deleted the fix-template-finding branch June 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants