Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle R CMD check crashes better #163

Merged
merged 8 commits into from
Sep 22, 2021
Merged

Handle R CMD check crashes better #163

merged 8 commits into from
Sep 22, 2021

Conversation

gaborcsardi
Copy link
Member

Now we throw an error if R CMD check exits with an
exit status greater than 1. (It exists with 1 if the
package fails to install, which we don't want to
error on.)

Closes #110.

Now we throw an error if R CMD check exits with an
exit status greater than 1. (It exists with 1 if the
package fails to install, which we don't want to
error on.)

Closes #110.
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #163 (4a340a6) into master (279fa1b) will decrease coverage by 0.47%.
The diff coverage is 58.82%.

❗ Current head 4a340a6 differs from pull request most recent head c42f338. Consider uploading reports for the commit c42f338 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   81.57%   81.09%   -0.48%     
==========================================
  Files          19       19              
  Lines         993     1005      +12     
==========================================
+ Hits          810      815       +5     
- Misses        183      190       +7     
Impacted Files Coverage Δ
R/package.R 88.29% <56.25%> (-6.83%) ⬇️
R/background.R 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279fa1b...c42f338. Read the comment docs.

- need to encode file name string when generating code.
- tools::pskill() does not work on windows, use ps.
Give more time for the rcmdcheck R process to exit.
It crashes on Windows.
They are unstable.
They must be ASCII to work on Windows.
readChar() converts \n to \r\n on Windows...
@gaborcsardi gaborcsardi merged commit cabc75f into master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle R CMD check crash / error
2 participants