Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve arg_match() message based on context #1733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jul 11, 2024

fixes #1682
fixes #1635

This feels a bit hack-ish, but I did this to avoid adding multiple everywhere in the C core. (I tried and failed)

Basically, you only need the option when writing the error message.

Also printing all incorrect parts of x instead of just the first one.

Tweak wording based on number of values and whether multiple values are accepted.

There is no easy fix for showing all incorrect values of x due to the way arg_match(multiple = TRUE) is implemented (loop instead of checking everything at once)

Happy to receive feedback for this.

I think it is important to have a different error message if multiple = TRUE. Up to now, I am using tryCatch() in my script to make sure a good and informative message is outputed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant