Improve arg_match()
message based on context
#1733
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1682
fixes #1635
This feels a bit hack-ish, but I did this to avoid adding
multiple
everywhere in the C core. (I tried and failed)Basically, you only need the option when writing the error message.
Also printing all incorrect parts of
x
instead of just the first one.Tweak wording based on number of values and whether multiple values are accepted.
There is no easy fix for showing all incorrect values of
x
due to the wayarg_match(multiple = TRUE)
is implemented (loop instead of checking everything at once)Happy to receive feedback for this.
I think it is important to have a different error message if
multiple = TRUE
. Up to now, I am usingtryCatch()
in my script to make sure a good and informative message is outputed.