Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use raw strings (from R 4.0) #1220

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@@ -29,7 +25,7 @@ remove_roxygen_mask <- function(text) {
#' #' @examples c(1, 2)
#' @keywords internal
remove_roxygen_header <- function(text) {
gsub("^[\\s\t]*@examples(If)?(\\s|\t)*", "", text, perl = TRUE)
gsub(R"(^[\s\t]*@examples(If)?(\s|\t)*)", "", text, perl = TRUE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a bug? That is, should this actually have been \\s|\\t?

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e053166 is merged into main:

  • ✔️cache_applying: 273ms -> 275ms [-9.13%, +10.11%]
  • ✔️cache_recording: 775ms -> 767ms [-6.44%, +4.28%]
  • ✔️without_cache: 1.27s -> 1.28s [-2.73%, +4.66%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant