Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvement in caching #679

Merged
merged 6 commits into from
Nov 1, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Oct 18, 2020

Don't convert transformers to character. We have version and name, this is sufficient. Goal is also to see if this is reflected in continuous benchmarking.
dccfa

  • cache_appyling: 0.095 -> 0.04 (-58%)
  • cache_recording: 1.258 -> 1.106 (-12%)
  • without_cache: 3.17 -> 3.319 (5%)

6535ba1 (wait: 0.003)

  • cache_appyling: 0.095 -> 0.039 (-59%)
  • cache_recording: 1.258 -> 1.073 (-15%)
  • without_cache: 3.17 -> 3.33 (+5%)

7cac0f1 (wait: 0.004)

  • cache_appyling: 0.095 -> 0.047 (-51%)
  • cache_recording: 1.258 -> 1.324 (+5%)
  • without_cache: 3.17 -> 3.98 (+26%)

75176a6

  • cache_appyling: 0.105 -> 0.038 (-64%)
  • cache_recording: 1.371 -> 1.085 (-21%)
  • without_cache: 3.632 -> 3.555 (-2%)

Major speed improvements are expected for cache_appyling and cache_recording, but without_cache should not change at all but is 5% slower.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #679 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   90.43%   90.42%   -0.01%     
==========================================
  Files          47       47              
  Lines        2226     2225       -1     
==========================================
- Hits         2013     2012       -1     
  Misses        213      213              
Impacted Files Coverage Δ
R/utils-cache.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708b1a1...75176a6. Read the comment docs.

@lorenzwalthert lorenzwalthert force-pushed the drop-as-character branch 3 times, most recently from 7cac0f1 to d0ff48a Compare October 25, 2020 22:25
@lorenzwalthert lorenzwalthert merged commit a2a2e2e into r-lib:master Nov 1, 2020
@lorenzwalthert lorenzwalthert deleted the drop-as-character branch November 1, 2020 17:27
@lorenzwalthert lorenzwalthert mentioned this pull request Nov 3, 2020
@lorenzwalthert lorenzwalthert restored the drop-as-character branch November 28, 2020 11:31
@lorenzwalthert lorenzwalthert deleted the drop-as-character branch November 28, 2020 21:25
@lorenzwalthert lorenzwalthert restored the drop-as-character branch February 20, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants