make vec_restore(<AsIs>) apply AsIs to the restored object, not its proxy #1903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a weird ggplot2 bug when using
I(...)
with some aesthetics that I eventually traced back to a bug in the implementation ofvec_restore.AsIs()
. It currently applies the"AsIs"
class to the proxy of the wrapped type without actually restoring the underlying type. I believe this is a simple fix.Before:
Created on 2023-12-21 with reprex v2.0.2
After:
Created on 2023-12-21 with reprex v2.0.2