Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter duplicates in track_sensor #396

Closed
lucas-johnson opened this issue Nov 25, 2020 · 2 comments
Closed

Filter duplicates in track_sensor #396

lucas-johnson opened this issue Nov 25, 2020 · 2 comments
Assignees
Labels
Feature request Asking for a new feature

Comments

@lucas-johnson
Copy link

Potential fix for this kind of problem: #392 (comment)

It might be nice to filter out duplicates in the track_sensor() function. Filtering these duplicates will not change the underlying data but will only be used to compute the sensor positions so it seems pretty safe.

track_sensor.LAScluster <- function(las, algorithm, extra_check = TRUE, thin_pulse_with_time = 0.001, multi_pulse = FALSE)
{
  x <- readLAS(las)
  if (is.empty(x)) return(NULL)
  x <- filter_duplicates(x)
  pos  <- track_sensor(x, algorithm, extra_check, thin_pulse_with_time, multi_pulse)
  return(pos)
}
@Jean-Romain Jean-Romain self-assigned this Nov 25, 2020
@Jean-Romain Jean-Romain added the Feature request Asking for a new feature label Nov 25, 2020
@Jean-Romain
Copy link
Collaborator

Do agree

@Jean-Romain Jean-Romain changed the title Feature request: filter duplicates in track_sensor Filter duplicates in track_sensor Feb 1, 2021
Jean-Romain added a commit that referenced this issue May 27, 2021
@Jean-Romain
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Asking for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants