fixes bug where simple features with geometry column not named... #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try" would throw an error Using sf::st_geometry() to access the geometry column of a simple feature ensures the geometry column (whatever it may be called) is used to get the geometry. If $geometry is used and the geometry column is called something different (e.g., lots of real-world instances where geometry column is called "geom") then NULL results, and sf::st_as_text() throws an error.
|
Thank you for the fix. Merged in |
Jean-Romain
added a commit
that referenced
this pull request
Mar 26, 2020
|
Right on! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..."geometry" would throw an error
Using sf::st_geometry() to access the geometry column of a simple feature ensures the geometry column (whatever it may be called) is used to get the geometry. If $geometry is used and the geometry column is called something different (e.g., lots of real-world instances where geometry column is called "geom") then NULL results, and sf::st_as_text() throws an error.