Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette on using QGIS expressions with qgisprocess #143

Merged
merged 22 commits into from
Mar 27, 2023
Merged

Conversation

florisvdh
Copy link
Member

@florisvdh florisvdh commented Mar 23, 2023

This vignette more or less depends on QGIS>=3.30 for some more involved cases. Some new features were recently added to QGIS to make more things possible in this area from R (qgis/QGIS#50481 & PR qgis/QGIS#51293; qgis/QGIS#50482 & PR qgis/QGIS#51412).

@jannes-m if you can propose other examples, feel free to do so.

Task list:

  • add example(s) for data-defined overrides

@florisvdh florisvdh requested a review from jannes-m March 23, 2023 18:05
@florisvdh florisvdh mentioned this pull request Mar 24, 2023
@florisvdh florisvdh mentioned this pull request Mar 24, 2023
florisvdh and others added 2 commits March 24, 2023 20:06
The error is just avoided by skipping a code chunk on Windows...

The error being:

Quitting from lines 98-105 (C:/Users/runneradmin/AppData/Local/Temp/RtmpMTIOIS/Rbuild1bb4257c5a60/qgisprocess/man/vignette_childs/_qgis_expressions.Rmd)
Quitting from lines 34-36 (C:/Users/runneradmin/AppData/Local/Temp/RtmpMTIOIS/Rbuild1bb4257c5a60/qgisprocess/man/vignette_childs/_qgis_expressions.Rmd)
Error: Error: processing vignette 'qgis_expressions.Rmd' failed with diagnostics:
! System command 'cmd.exe' failed
--- failed re-building 'qgis_expressions.Rmd'
SUMMARY: processing the following file failed:
  'qgis_expressions.Rmd'

This may hint at a possible windows-specific bug in qgis_process, e.g. involving
the new QGIS function load_layer().
To be checked!!
An example is provided by the `DISTANCE` argument of `native:buffer`, for which we query the acceptable values below.

```{r}
qgis_arguments("native:buffer") |>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With QGIS 3.28.2 this results it:

|acceptable_values |
|:-----------------|
|A numeric value   |

Not sure, if this is the desired result

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, later on you say that this is only possible with QGIS 3.30 onwards, ok

Copy link
Collaborator

@jannes-m jannes-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this really interesting and useful vignette!

@florisvdh
Copy link
Member Author

Thanks for reviewing and updating!

@florisvdh florisvdh merged commit b01952e into main Mar 27, 2023
@florisvdh florisvdh deleted the vign_qgis_3.30 branch March 27, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants