Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add libsodium #333

Merged
merged 2 commits into from
Dec 18, 2023
Merged

add libsodium #333

merged 2 commits into from
Dec 18, 2023

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Dec 14, 2023

For the CRAN package sodium.

georgestagg
georgestagg approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@georgestagg georgestagg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A minor tweak is suggested below, after which I'm happy to merge.

P.S. Don't mind the CI failure in build-nix.

libs/recipes/sodium/rules.mk Show resolved Hide resolved
@georgestagg georgestagg merged commit 20f3b1c into r-wasm:main Dec 18, 2023
0 of 2 checks passed
@jeroen jeroen deleted the sodium branch December 18, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgestagg georgestagg georgestagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroen @georgestagg