Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help and debug targets, fuzzy assign WEBR_ROOT #410

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

coatless
Copy link
Contributor

As part of digging into the build process, I thought it would be helpful to add to the top-level Make file:

  1. a debug variables statement; and,
Screenshot showing the results of `make debug`
  1. a help documentation statement.
Screenshot showing the results of `make help`

I've also moved to use a conditional assignment for WEBR_ROOT so that it is read from the environment variable set up in the Dockerfile. (Note: There are a few more changes required for this to be portable, but I wanted to start small.)

I'll likely add a similar patch for each subsequent makes if okay.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@georgestagg georgestagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

I've made some minor wording suggestions, apologies for being quite picky here.

coatless and others added 8 commits April 23, 2024 10:36
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
Co-authored-by: George Stagg <[email protected]>
@coatless
Copy link
Contributor Author

@georgestagg no worries. Added the suggestions. This should be ready for a merge when you a moment.

@georgestagg georgestagg merged commit 3eef6fc into r-wasm:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants