Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to stable2407 #10

Merged
merged 15 commits into from
Nov 8, 2024

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Sep 24, 2024

@chungquantin chungquantin marked this pull request as draft September 24, 2024 16:03
@chungquantin chungquantin marked this pull request as ready for review September 25, 2024 08:26
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the changes in the README?

@chungquantin
Copy link
Collaborator Author

@AlexD10S I think because of my local markdown formatter, let me revert back.

Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the update to the parachain is well done.
Although, I'd remove the changes in the README file before merging.

One thing that would be great is having all the templates using something different than rococo-local for the relay chain as Rococo stopped running in Oct.
Logged that for a follow up: r0gue-io#51

@AlexD10S AlexD10S self-requested a review November 7, 2024 21:55
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Ale said let's remove the README changes, rest looks good to me

@chungquantin chungquantin merged commit 92ea89b into main Nov 8, 2024
6 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-polkadot-stable2407 branch November 8, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants