feat: clean dmpq state at genesis #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
requested changes
Aug 9, 2024
evilrobot-01
approved these changes
Aug 10, 2024
evilrobot-01
changed the title
evilrobot-01
pushed a commit
that referenced
this pull request
Aug 10, 2024
* dispatch kill tx * paseo-local metadata * chore: address hrmp channels at creation * clean unnecessary deps * fix: don't wait for finalisation * Provide documentation
evilrobot-01
pushed a commit
that referenced
this pull request
Oct 10, 2024
* dispatch kill tx * paseo-local metadata * chore: address hrmp channels at creation * clean unnecessary deps * fix: don't wait for finalisation * Provide documentation
Daanvdplas
pushed a commit
that referenced
this pull request
Oct 24, 2024
* dispatch kill tx * paseo-local metadata * chore: address hrmp channels at creation * clean unnecessary deps * fix: don't wait for finalisation * Provide documentation
evilrobot-01
added a commit
that referenced
this pull request
Oct 24, 2024
* chore: release 0.4.0 (#318) * fix: bump version to 0.3.1 * fix: image in pop-cli README crate * chore: update changelog * fix: logo in pop-cli crate * fix: logo in pop-cli crate from onpop site * fix: remove unused images * fix: version 0.4.0 * chore: update version to 0.4.0 * build(deps): update zombienet-sdk to use fork * chore: switch pop network configuration to paseo with hrmp channels * test: add relay+asset hub network config files * feat: clean dmpq state at genesis (#279) * dispatch kill tx * paseo-local metadata * chore: address hrmp channels at creation * clean unnecessary deps * fix: don't wait for finalisation * Provide documentation * refactor: improve ux * feat: add rococo-local metadata * fix: resolve merge conflict * chore: update zombienet-sdk * feat: ismp relaying * refactor: use dynamic tx for clearing dmpq state --------- Co-authored-by: Alex Bean <[email protected]> Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Alejandro Martinez Andres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HRMP channels need to be open at genesis the dmq state on the relay needs to match the one in the parachains.
This is not the case in the current state of zombienet, so the changes in this MR take care of cleaning the dmq state in the relay so HRMP channels can be open at genesis.
Follow up work:
A sensible next step would be reading the values from the relevant keys in the parachains and writing those in the relay state. As this change stands right now it would work nicely with parachains that have clean state for the dmqs. Usually that's the state of a parachain that is to be launched, but just in case the mentioned improvements should fit all scenarios.