Fix CA certs overriding server certs #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test became ineffective after #1735. We want to enable Web MQTT/STOMP TLS regardless of whether a CA bundle certificate is provided. This test was asserting that we enable web stomp/mqqt tls when the CA bundle is set; however, by not setting the CA bundle, the test passes anyway. This is not correct, making the test ineffective.
Related to #1616
Due to changes in the spec code comments.
mkuratczyk
approved these changes
Oct 14, 2024
MirahImage
approved these changes
Oct 14, 2024
|
@Zerpet nice fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1616
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Additional Context
More information and repro steps in #1616
Local Testing
Unit and integration tests are passing.