Add default queue type config to vhost crd #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- can be set to quorum, classic or stream this property can only be set for RMQ 3.11.12 or above. Version previous to 3.11.12 will fail to reconcile if it's set
Zerpet
approved these changes
May 29, 2023
MirahImage
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #608
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Default queue type for a vhost can be set to quorum, classic or stream. This configuration requires RabbitMQ
3.11.12.Field
spec.defaultQueueTypeis mutable but currently updating it takes no effect. Default queue type can be updated withrabbitmqctlbut not via http at the moment. I've added it in PR: rabbitmq/rabbitmq-server#8342. After this PR to rabbitmq-server is merged and released, default queue type can be updated with topology operator successfully.Update on May 30th, PR to rabbitmq-server is merged and will be related for
3.11.17.Additional Context