Add topology recovery started method to RecoveryListener #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikinghawk
commented
Feb 15, 2021
| @@ -560,7 +560,10 @@ public void removeConsumerRecoveryListener(ConsumerRecoveryListener listener) { | |||
| } | |||
|
|
|||
| private synchronized void beginAutomaticRecovery() throws InterruptedException { | |||
| this.wait(this.params.getRecoveryDelayHandler().getDelay(0)); | |||
| final long delay = this.params.getRecoveryDelayHandler().getDelay(0); | |||
| if (delay > 0) { | |||
There was a problem hiding this comment.
i had tried to use a backoff recovery delay handler that had an initial delay of 0 and quickly realized that recovery would hang forever here. An easy work around is to use a 1ms initial delay, but this feels like a better solution that may save someone else in the future.
There was a problem hiding this comment.
This is reasonable if you ask me.
michaelklishin
approved these changes
Feb 15, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds a default method to the RecoveryListener interface that notifies the listener when connection & channel recovery is complete and that topology recovery is now starting.
Once the connection & channels have been recovered, it is safe for an application to start publishing messages again. For connections that have a lot of queues/bindings/consumers to recover, it can be useful for applications to know this intermediary state and not have to wait for all of the subscription related entities to be fully recovered.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.