Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rules_elixir for rabbitmqctl (backport #11456) (backport #11485) #11510

Merged
merged 13 commits into from
Jun 22, 2024
Merged

Use rules_elixir for rabbitmqctl (backport #11456) (backport #11485) #11510

merged 13 commits into from
Jun 22, 2024

Commits on Jun 20, 2024

  1. Use rules_elixir to build the cli without mix 

    Certain elixir-native deps are still build with mix, but this can be
corrected later

(cherry picked from commit 5debebf)

# Conflicts:
#	deps/rabbit/BUILD.bazel
(cherry picked from commit 7f585d4)

# Conflicts:
#	deps/rabbitmq_cli/BUILD.bazel
#	deps/rabbitmq_ct_helpers/BUILD.bazel
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    714f31a View commit details
    Browse the repository at this point in the history

  2. Add erlang binaries to the path in rabbitmq-run.sh 

    As they are no longer added automatically by the enclosing rule

(cherry picked from commit 35171eb)
(cherry picked from commit 04d6dc4)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7ac73c3 View commit details
    Browse the repository at this point in the history

  3. Set the locale with elixir 

    (cherry picked from commit ba8cf2c)
(cherry picked from commit 1d11854)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a6f5018 View commit details
    Browse the repository at this point in the history

  4. amqp_client system_SUITE apparently needs the cli on the code path 

    I'm not actually sure why the changes to rabbitmqctl compilation
necessitated this change, but it seems to be the case

(cherry picked from commit 662ad8e)
(cherry picked from commit 2287a84)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    36ddf89 View commit details
    Browse the repository at this point in the history

  5. Check that the cli can compile with --warnings-as-errors in ci 

    It's technically a build target, so we didn't need to create a whole
new test rule, but it's marked as "manual" so that it doesn't cause
bazel build //... to fail

(cherry picked from commit f2add66)
(cherry picked from commit 7e8c959)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    feebd98 View commit details
    Browse the repository at this point in the history

  6. use the latest bazel_skylib 

    (cherry picked from commit a6b3916)
(cherry picked from commit 1de9bb9)

# Conflicts:
#	MODULE.bazel
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b7ee1de View commit details
    Browse the repository at this point in the history

  7. use the latest rules_erlang 

    which fixes and issue with escript_archive that was breaking the rabbitmqctl escript

(cherry picked from commit 5fc8a8c)
(cherry picked from commit 0ce73ff)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    634ab9d View commit details
    Browse the repository at this point in the history

  8. ensure that csv and json elixir deps are embedded in the cli escript 

    also set 'cfg =' appropriately

(cherry picked from commit 46250dc)
(cherry picked from commit 306c593)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3796fbb View commit details
    Browse the repository at this point in the history

  9. fixup backport 

    (cherry picked from commit f73af61)
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6a456cc View commit details
    Browse the repository at this point in the history

  10. fixup backport

    @HoloRin
    HoloRin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    db459f0 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'v3.12.x' into mergify/bp/v3.12.x/pr-11485

    @HoloRin
    HoloRin authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b7673a7 View commit details
    Browse the repository at this point in the history

  12. Don't check for cli compilation errors

    @HoloRin
    HoloRin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c19d6f8 View commit details
    Browse the repository at this point in the history

  13. Mark //deps/rabbitmq_cli:tests as large 

    for a larger timeout
    @HoloRin
    HoloRin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3362965 View commit details
    Browse the repository at this point in the history