For 4.0: Require all stable feature flags added up to 3.13.0 #11659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
changed the title
ansd
force-pushed
the
require-feature-flags
branch
2 times, most recently
from
7b811ec
to
db097b0
Compare
Since feature flag `message_containers` introduced in 3.13.0 is required in 4.0, we can also require all other feature flags introduced in or before 3.13.0 and remove their compatibility code for 4.0: * restart_streams * stream_sac_coordinator_unblock_group * stream_filtering * stream_update_config_command
This test case was wrongly skipped and therefore never ran.
ansd
force-pushed
the
require-feature-flags
branch
from
db097b0
to
6cdfb62
Compare
dumbbell
reviewed
Jul 10, 2024
dumbbell
reviewed
Jul 10, 2024
as suggested by JSP in PR feedback
dumbbell
approved these changes
Jul 11, 2024
acogoluegnes
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since feature flag
message_containersintroduced in 3.13.0 is required in 4.0, we can also require all other feature flags introduced in or before 3.13.0 and remove their compatibility code for 4.0:restart_streamsstream_sac_coordinator_unblock_groupstream_filteringstream_update_config_commandRelated to #11642