client_secret should be optional when using authorization code flow #6201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ Management UI is a considered a public client application in the context of OAuth 2.0 spec. That means that it is exposed and hence any credentials or secrets cannot be securely stored, such as
client_secret
.Authorization Code flow with PKCE does not need the client application to send its
client_secret
to get the access_token once it obtained an authorization code. PKCE is used instead.Note: When using UAA, registered clients must be configured with the flag
allowpublic: true
otherwise the client assumes it is a confidential client and it expects aclient_secret
to get the access token.We have not entirely removed the
management.oauth_client_secret
setting from the management plugin. Instead, only when it is configured, it is used by the plugin. This is so that there is an authorization server that requires it. But it is not mandatory any more.Validate that we can use Authorization code flow with PKCE without
client_secret
against:(manual means it was manually validated using rabbitmq-oauth2-tutorial
This PR also includes:
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.