QQ: do not add x-delivery-count header for the first delivery. #7732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x-delivery-count header only needs to be added when a message is redelivered. Adding it on the first delivery attempt is unnecessary, not recorded in the quorum queue documentation and causes additional work deserialising the binary basic properties data to add this header. This could be notable for messages with substantial property data incl. heavy use of headers for example.
ansd
previously approved these changes
Mar 24, 2023
ansd
approved these changes
Mar 24, 2023
michaelklishin
added a commit
that referenced
this pull request
Mar 24, 2023
QQ: do not add x-delivery-count header for the first delivery. (backport #7732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x-delivery-count header only needs to be added when a message is redelivered. Adding it on the first delivery attempt is unnecessary, not recorded in the quorum queue documentation and causes additional work deserialising the binary basic properties data to add this header.
This could be notable for messages with substantial property data incl. heavy use of headers for example.
NB: there is a chance some client applications have a dependency on this header being there for the very first delivery.