Fix rabbit_stream_queue:get_counters querying writer last #8269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
rabbit_steam_coordinator:stream_overview/1
returns the member indifferent format than
members/1
, resulting inis_writer/1
nevermatching. This was changed in PR #6440. This prevents getting counters
from stream writer last as intended by PR #6442.
Tracing while calling
rabbitmq-queues stream_status sq1
Let me know if the change from
members/1
tostream_overview/1
was intentional and I can rework this change.#6440 was only included in 3.12. (This is not a big issue but) this change makes a followup PR of mine easier to be applied to both 3.12 and 3.10/3.11.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.