Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compareCollections to return an implementation of Collection #110

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

martinvisser
Copy link
Contributor

By using generics instead of Collection<T> compareCollections will now return the type used rather than always Collection<T>.

This was not possible as it would return a Collection, not List

List<String> strings = shadowTool.compareCollections(()-> List.of("1"), () -> List.of("2"));

@martinvisser martinvisser requested a review from a team as a code owner November 13, 2023 18:30
@martinvisser martinvisser force-pushed the compare-collections-always-returns-collection branch from d8c2923 to 56f5f4b Compare November 15, 2023 08:21
aaukhatov
aaukhatov previously approved these changes Nov 15, 2023
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martinvisser martinvisser merged commit 499f57e into main Nov 15, 2023
3 checks passed
@martinvisser martinvisser deleted the compare-collections-always-returns-collection branch November 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants