add option to provide a cipher #59

[mdpadberg]

add option to provide a cipher #59

[martinvisser]

Thanks for the PR, but I have some questions/remarks. I do not see a reason why we need an interface for the encryption service. We could opt for the current EncryptionService and if no Cipher is defined it would use the current default Cipher. If the "old" withEncryption(PublicKey) is used, it could init the Cipher and basically call withCipher(Cipher) method. This would mean there is no need for multiple classes to implement an interface, the EncryptionService will always be initialized with a Cipher.

We also might need to clarify that calling both withEncryption and withCipher will override each other, that's not clear in the docs.

[mdpadberg]

Thanks for the PR, but I have some questions/remarks. I do not see a reason why we need an interface for the encryption service. We could opt for the current EncryptionService and if no Cipher is defined it would use the current default Cipher. If the "old" withEncryption(PublicKey) is used, it could init the Cipher and basically call withCipher(Cipher) method. This would mean there is no need for multiple classes to implement an interface, the EncryptionService will always be initialized with a Cipher.

We also might need to clarify that calling both withEncryption and withCipher will override each other, that's not clear in the docs.

Updated the javadocs. Also changed the design from the EncryptionService interface to the builder, like you suggested

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information