Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better .gitignore file #264

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

mdedetrich
Copy link
Collaborator

This .gitignore is generated from Intellij and is more comprehensive then the current one.

@mdedetrich mdedetrich requested a review from raboof July 28, 2023 09:05
@raboof
Copy link
Owner

raboof commented Jul 28, 2023

did you run into any of these? I think it's useful when unexpected temporary files mark the repo dirty

@mdedetrich
Copy link
Collaborator Author

mdedetrich commented Jul 28, 2023

did you run into any of these? I think it's useful when unexpected temporary files mark the repo dirty

Are you talking about current .gitignore or the new one? I have been using the proposed .gitignore in my projects and have experienced zero issues with it. For example some sbt plugins (i.e. metals/bloop iirc) can create files in project/plugins/project/ which this .gitignore handles.

@raboof
Copy link
Owner

raboof commented Dec 31, 2023

While generally I prefer IDE-related gitignore statements to go into your own global gitignore instead of into each repo you contribute to, let's get this merged :)

@raboof raboof merged commit 4e16ca2 into raboof:main Dec 31, 2023
2 checks passed
@mdedetrich mdedetrich deleted the use-better-gitignore branch December 31, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants